[Lazarus] [PATCH] Don't force ProductVersion to be equal to FileVersion if it's not set

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Lazarus] [PATCH] Don't force ProductVersion to be equal to FileVersion if it's not set

Free Pascal - Lazarus mailing list
Hi again.
 
This patch fixes forced setting of ProductVersion if it's not set, but FileVersion is.
This also makes code style slightly more consistent: now we access FStringTable everywhere instead of StringTable.
This also removes double assignment of FStringTable['FileVersion'] somewhere.
 
Based on the Lazarus trunk.
_____
 
Dmitry D. Chernov

--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus

w32versioninfo.pas.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] [PATCH] Don't force ProductVersion to be equal to FileVersion if it's not set

Free Pascal - Lazarus mailing list
Oh, I'm so sorry, the patch from my previous mail IS WRONG. Here's a correct one.
 
_____
 
Dmitry D. Chernov
 
05.10.2017, 05:34, "Dmitry D. Chernov via Lazarus" <[hidden email]>:
Hi again.
 
This patch fixes forced setting of ProductVersion if it's not set, but FileVersion is.
This also makes code style slightly more consistent: now we access FStringTable everywhere instead of StringTable.
This also removes double assignment of FStringTable['FileVersion'] somewhere.
 
Based on the Lazarus trunk.
_____
 
Dmitry D. Chernov
,--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus

--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus

w32versioninfo.pas.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] [PATCH] Don't force ProductVersion to be equal to FileVersion if it's not set

Free Pascal - Lazarus mailing list
Is it related to issue:
 https://bugs.freepascal.org/view.php?id=32333
?
If yes, please upload the patch there.
Bug tracker is the recommended way to deal with patches anyway.

Juha
--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] [PATCH] Don't force ProductVersion to be equal to FileVersion if it's not set

Free Pascal - Lazarus mailing list
Only indirectly. This neither closes the issue nor implements something else. This just closes minor bug and slightly fixes code style.
 
_____
 
Dmitry D. Chernov
 
05.10.2017, 09:08, "Juha Manninen via Lazarus" <[hidden email]>:

Is it related to issue:
 https://bugs.freepascal.org/view.php?id=32333
?
If yes, please upload the patch there.
Bug tracker is the recommended way to deal with patches anyway.

Juha

--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus

--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus