[Lazarus] IDE Spotter- issues

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[Lazarus] IDE Spotter- issues

Free Pascal - Lazarus mailing list
3- better add inner (inside listbox) left indent of text: 3-4pix.

4- right indent is too big (15-20pix even with scrollbar), use same
3-4pix as left (considering scrollbar)

--
Regards,
Alexey

--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] IDE Spotter- issues

Free Pascal - Lazarus mailing list


On Mon, 24 Sep 2018, AlexeyT via Lazarus wrote:

> 3- better add inner (inside listbox) left indent of text: 3-4pix.

Will do.

> 4- right indent is too big (15-20pix even with scrollbar), use same
> 3-4pix as left (considering scrollbar)

Currently, the scroll bar width as reported is always used as indent, plus The 'W' width.
Without it, the shortcut key was never drawn correctly.

How do I know if the scrollbar is visible ?

Michael.
--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] IDE Spotter- issues

Free Pascal - Lazarus mailing list


On Mon, 24 Sep 2018, AlexeyT wrote:

>
>>
>> How do I know if the scrollbar is visible ?
>
> TListbox.ClientWidth gives width considering scrollbar.

OK, thank you.
But should not the Rect in the ListBox OnDrawItem already take this into account ?

Michael.
--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] IDE Spotter- issues

Free Pascal - Lazarus mailing list
In reply to this post by Free Pascal - Lazarus mailing list


On Mon, 24 Sep 2018, AlexeyT wrote:

>
>>
>> How do I know if the scrollbar is visible ?
>
> TListbox.ClientWidth gives width considering scrollbar.

I committed a new version with some visual improvements and bugfixes:

* Actually load saved options on startup :)
* Button to go to settings
* Margins around controls
* Better Left and right margin inside listbox
* Use different default colors (maroon, navy)
* Handle keydown instead of key up, so repeat is enabled...

Michael.
--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] IDE Spotter- issues

Free Pascal - Lazarus mailing list
On 25/09/18 09:07, Michael Van Canneyt via Lazarus wrote:

>
>
> On Mon, 24 Sep 2018, AlexeyT wrote:
>
>>
>>>
>>> How do I know if the scrollbar is visible ?
>>
>> TListbox.ClientWidth gives width considering scrollbar.
>
> I committed a new version with some visual improvements and bugfixes:
>
> * Actually load saved options on startup :)
> * Button to go to settings
> * Margins around controls
> * Better Left and right margin inside listbox
> * Use different default colors (maroon, navy)
> * Handle keydown instead of key up, so repeat is enabled...
>
> Michael.

A further issue: Spotter appears not to know about menu items added by
some packages.

For instance, LazProfiler adds three new menu items to the IDE, but
Spotter does not list them.

Howard

--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] IDE Spotter- issues

Free Pascal - Lazarus mailing list


On Tue, 25 Sep 2018, Howard Page-Clark via Lazarus wrote:

> On 25/09/18 09:07, Michael Van Canneyt via Lazarus wrote:
>>
>>
>> On Mon, 24 Sep 2018, AlexeyT wrote:
>>
>>>
>>>>
>>>> How do I know if the scrollbar is visible ?
>>>
>>> TListbox.ClientWidth gives width considering scrollbar.
>>
>> I committed a new version with some visual improvements and bugfixes:
>>
>> * Actually load saved options on startup :)
>> * Button to go to settings
>> * Margins around controls
>> * Better Left and right margin inside listbox
>> * Use different default colors (maroon, navy)
>> * Handle keydown instead of key up, so repeat is enabled...
>>
>> Michael.
>
> A further issue: Spotter appears not to know about menu items added by
> some packages.
>
> For instance, LazProfiler adds three new menu items to the IDE, but
> Spotter does not list them.


I don't know how lazprofiler installs itself, so I can't comment.

But in general, I suppose that is possible.  It only lists available commands.
If a package installs a menu item without a command, then it will not be visible in the spotter...

See it as an incentive for package maintainers to install commands instead
of simply menu items : I can imagine that installing commands also makes
them available for e.g. the editor toolbar.

But I suppose some lazarus dev needs to comment on the exact inner workings.

Michael.
--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] IDE Spotter- issues

Free Pascal - Lazarus mailing list
In reply to this post by Free Pascal - Lazarus mailing list

I committed a new version with some visual improvements and bugfixes:

* Actually load saved options on startup :)
* Button to go to settings
* Margins around controls
* Better Left and right margin inside listbox
* Use different default colors (maroon, navy)
* Handle keydown instead of key up, so repeat is enabled...


1. Standard for margins around controls in Lazarus is 6 pixels. Now is lesser. This is very noticeable visually.

2. Spotter does not respect IDE option "Prefer double-click over single-click". It is very uncomfortable for people who prefer double click in lists.

--
FTurtle


--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] IDE Spotter- issues

Free Pascal - Lazarus mailing list


On Tue, 25 Sep 2018, FTurtle via Lazarus wrote:

>
>> I committed a new version with some visual improvements and bugfixes:
>>
>> * Actually load saved options on startup :)
>> * Button to go to settings
>> * Margins around controls
>> * Better Left and right margin inside listbox
>> * Use different default colors (maroon, navy)
>> * Handle keydown instead of key up, so repeat is enabled...
>>
>
> 1. Standard for margins around controls in Lazarus is 6 pixels. Now is lesser. This is very noticeable visually.

Really ? You must have 100/10 vision. I don't see any difference.

But I can say with certainty the IDE is not consistent in this regard, e.g.
the project inspector uses different spacing than the IDE Options dialog.
The only reason I saw that is because of your remark I started putting
things side by side.

>
> 2. Spotter does not respect IDE option "Prefer double-click over single-click". It is very uncomfortable for people who prefer double click in lists.

Really ? I did not know all these things.

The single click was chosen because this is how it works in Atom.

Where are all these options or rules described ?

Because the IDE Tools - Options page does not contain such a setting.
Or at least, I didn't find it.

If I select something, it's always single click.
Project inspector, IDE Tools - Options treeview. Everywhere.

Michael.
--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] IDE Spotter- issues

Free Pascal - Lazarus mailing list

> 1. Standard for margins around controls in Lazarus is 6 pixels. Now is lesser. This is very noticeable visually.

Really ? You must have 100/10 vision. I don't see any difference.

But I can say with certainty the IDE is not consistent in this regard, e.g.
the project inspector uses different spacing than the IDE Options dialog.
The only reason I saw that is because of your remark I started putting
things side by side.

Read wiki:
http://wiki.lazarus.freepascal.org/GUI_design_guidelines#Spacings_and_sizes

"Spacing between elements: 6 pixels."

> 2. Spotter does not respect IDE option "Prefer double-click over single-click". It is very uncomfortable for people who prefer double click in lists.

Really ? I did not know all these things.

The single click was chosen because this is how it works in Atom.

Where are all these options or rules described ?

Because the IDE Tools - Options page does not contain such a setting.
Or at least, I didn't find it.

Don't forget about filter. Just insert "do".
It placed here:
Tools/Options/Environment/General/Section "Mouse Action", Checkbox "Prefer double-click over single-click".

If I select something, it's always single click.
Project inspector, IDE Tools - Options treeview. Everywhere.

This option has an impact, in particular, on "Search results" form, "ToDo List" and etc. 

--
FTurtle


--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] IDE Spotter- issues

Free Pascal - Lazarus mailing list



More suitable quote from wiki:
http://wiki.lazarus.freepascal.org/GUI_design_guidelines#BorderSpacing 

"A typical borderspacing of 6 pixels around a component is used."

--
FTurtle


--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus
Reply | Threaded
Open this post in threaded view
|

Re: [Lazarus] IDE Spotter- issues

Free Pascal - Lazarus mailing list
In reply to this post by Free Pascal - Lazarus mailing list


On Tue, 25 Sep 2018, FTurtle via Lazarus wrote:

>> The single click was chosen because this is how it works in Atom.
>>
>> Where are all these options or rules described ?
>>
>> Because the IDE Tools - Options page does not contain such a setting.
>> Or at least, I didn't find it.
> Don't forget about filter. Just insert "do".
> It placed here:
> Tools/Options/Environment/General/Section "Mouse Action", Checkbox "Prefer double-click over single-click".

I already found it.
It's not available in packages, only forms internal to the IDE can access this setting.

>
>> If I select something, it's always single click.
>> Project inspector, IDE Tools - Options treeview. Everywhere.
> This option has an impact, in particular, on "Search results" form, "ToDo List" and etc. 

I discussed this with Mattias.
While the option you mention is useful for the windows you mention,
We think the IDE spotter is more like a dropdown in functionality.
So single click.

But I will change the spacing.

Michael.
--
_______________________________________________
Lazarus mailing list
[hidden email]
https://lists.lazarus-ide.org/listinfo/lazarus